Skip to content

Load arch data for backup from template during create instance from backup#12801

Merged
DaanHoogland merged 3 commits intoapache:4.22from
shapeblue:fixArchBackupUI
Apr 9, 2026
Merged

Load arch data for backup from template during create instance from backup#12801
DaanHoogland merged 3 commits intoapache:4.22from
shapeblue:fixArchBackupUI

Conversation

@sudo87
Copy link
Copy Markdown
Contributor

@sudo87 sudo87 commented Mar 12, 2026

Description

This PR fixes issue #12444

Arch info is fetched from the template and is used to fetch the relevant templates.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screen.Recording.2026-03-12.at.11.08.11.PM.mov

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes UI behavior when creating an instance from a backup in multi-arch zones by carrying over the source template’s architecture so template/ISO listings can be filtered consistently.

Changes:

  • Fetch template architecture during “Create VM from Backup” initialization and pass it via dataPreFill.
  • Initialize/adjust selected architecture in the deployment wizard based on prefilled template arch and selected template arch.
  • Remove the zone-selection-time forced architecture reset to avoid overriding the backup/template architecture.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
ui/src/views/storage/CreateVMFromBackup.vue Adds template-arch lookup and passes it to the deploy wizard via dataPreFill.
ui/src/components/view/DeployVMFromBackup.vue Uses prefilled template architecture to set selectedArchitecture, updates it on template selection, and changes zone-selection behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread ui/src/views/storage/CreateVMFromBackup.vue Outdated
Comment thread ui/src/components/view/DeployVMFromBackup.vue
Comment thread ui/src/views/storage/CreateVMFromBackup.vue
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (9fb0e71).
⚠️ Report is 27 commits behind head on 4.22.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12801      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
+ Complexity    15664    15662       -2     
============================================
  Files          5917     5917              
  Lines        531402   531395       -7     
  Branches      64971    64972       +1     
============================================
- Hits          93596    93588       -8     
+ Misses       427252   427251       -1     
- Partials      10554    10556       +2     
Flag Coverage Δ
uitests 3.70% <ø> (+<0.01%) ⬆️
unittests 18.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti added this to the 4.22.1 milestone Mar 13, 2026
@sureshanaparti sureshanaparti linked an issue Mar 13, 2026 that may be closed by this pull request
@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12801 (QA-JID-898)

@sudo87
Copy link
Copy Markdown
Contributor Author

sudo87 commented Mar 13, 2026

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12801 (QA-JID-899)

Copy link
Copy Markdown
Contributor

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 1ff9eec into apache:4.22 Apr 9, 2026
20 of 26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.1 Apr 9, 2026
@sureshanaparti sureshanaparti deleted the fixArchBackupUI branch April 10, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Backups don't retain arch info

6 participants